Skip to content

Don't show scrambler checker box when the competitor's nationalRanking equals 0 - #123

Merged
jonatanklosko merged 1 commit into
jonatanklosko:masterfrom
maxidragon:fix-scramble-checker-for-competitors-who-switched-nationality
Jul 19, 2026
Merged

Don't show scrambler checker box when the competitor's nationalRanking equals 0#123
jonatanklosko merged 1 commit into
jonatanklosko:masterfrom
maxidragon:fix-scramble-checker-for-competitors-who-switched-nationality

Conversation

@maxidragon

Copy link
Copy Markdown
Contributor

This will happen if the competitor switches nationality and haven't achieved PRs under new country yet, see example

{
  "name": "Axel Morley",
  "wcaUserId": 186124,
  "wcaId": "2022MORL01",
  "registrantId": 19,
  "countryIso2": "FR",
  "gender": "m",
  "personalBests": [
    {
      "eventId": "333oh",
      "best": 2178,
      "worldRanking": 9967,
      "continentalRanking": 2567,
      "nationalRanking": 0,
      "type": "average"
    }
  ]
}

@jonatanklosko
jonatanklosko merged commit 3135dfd into jonatanklosko:master Jul 19, 2026
5 checks passed
@maxidragon
maxidragon deleted the fix-scramble-checker-for-competitors-who-switched-nationality branch July 19, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants