Color gem expects 6 character hex string#33
Open
mrloop wants to merge 1 commit intojonbuda:masterfrom
Open
Conversation
The color gem expects hex color string with 3 or 6 digits, see: https://github.com/halostatue/color/blob/2159ca233851ca3304414b831d9da368dcbafb04/lib/color/rgb.rb#L609 When miro generates a histogram it uses `Color::RGB.from_html` however image magick can generate 8 character hex string on osx where the image contains an alpha channel. Using these and `from_html` raises an error. The PR tell image magick we want to discard the alpha channel info color strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #32 but deals with unwanted alpha channel info on osx.
The color gem expects hex color string with 3 or 6 digits, see:
https://github.com/halostatue/color/blob/2159ca233851ca3304414b831d9da368dcbafb04/lib/color/rgb.rb#L609
When miro generates a histogram it uses
Color::RGB.from_htmlhoweverimage magick can generate 8 character hex string on osx where the image
contains an alpha channel.
Using these and
from_htmlraises an error.The PR tell image magick we want to discard the alpha channel info color strings