feat(config): report keybinding conflicts#358
Merged
Conversation
Checks the active keybinding scheme during config validation and prints conflicts with their bound actions. Closes #355 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… constants Merges main into config-check branch, resolves the config.go keep-both conflict, and fixes pre-existing goconst failures (default scheme, CERTIFICATE PEM type) that were failing CI on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e1e7a2e9-8a0a-42dc-be96-9ac694fc55c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds keybinding conflict checks to
grut config check. The command now loads the active keybinding scheme, prints duplicate key/action conflicts, and exits non-zero when collisions are present.Closes #355
Validation:
go build ./...go test ./cmd ./internal/keymap -count=1go test ./... -count=1go vet ./...Note:
mage testWSLwas attempted, but the WSL update tests hit an unrelated existing/home/jong/.config/grut/grut-update.lock.