Port of Hasbrown #183 "Avoid closures to improve compile times"#14
Merged
jonhoo merged 6 commits intojonhoo:masterfrom Aug 9, 2020
mucinoab:hasbrown#183
Merged
Port of Hasbrown #183 "Avoid closures to improve compile times"#14jonhoo merged 6 commits intojonhoo:masterfrom mucinoab:hasbrown#183
jonhoo merged 6 commits intojonhoo:masterfrom
mucinoab:hasbrown#183
Conversation
closures to improve compile times".
Codecov Report
|
jonhoo
approved these changes
Aug 9, 2020
Owner
|
Ah, this is great, thank you! As long as you diff the code against the hashbrown code to make sure we match as closely as possible, it should be all good. It also looks like you should do future changes based off of the newest griddle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR. I think I got everything in but let me know of any thoughts you may have.