Add macOS targets to standalone release workflow#12
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9d890499
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - target: linux-x64 | ||
| runner: ubuntu-22.04 | ||
| - target: darwin-x64 | ||
| runner: macos-13 |
There was a problem hiding this comment.
Replace retired macOS runner label
Using macos-13 here breaks the release workflow on current GitHub-hosted runners: GitHub retired the macos-13 label on December 4, 2025, so this matrix entry now fails to start and causes the standalone job to fail for every tagged release run. This commit introduced that hard-coded label for the darwin-x64 build, so the x64 macOS artifact lane is effectively non-functional until it is moved to a supported Intel label (for example macos-15-intel/macos-14-large) or an arm-compatible strategy.
Useful? React with 👍 / 👎.
|
@codex fix review suggestion |
Summary
Testing
|
Motivation
Description
.github/workflows/standalone-release.ymlthat buildslinux-x64,darwin-x64, anddarwin-arm64, exposesTARGET/ARTIFACTenv vars, and uploads per-target artifacts.scripts/standalone/build.shto produce a platform-specific wrapper atdist/standalone/devcontainer-<target>and makescripts/standalone/build-linux-x64.shdelegate to it.shasum -a 256for cross-platform checksum creation and addsigstore/cosign-installer@v3.8.1to the workflow beforecosignsigning, plus update upload paths and artifact names to use the matrixARTIFACT.docs/standalone/distribution.mdanddocs/standalone/prototype.mdto reflect macOS target support and the Node SEA-style wrapper approach.Testing
bash -n scripts/standalone/build.sh scripts/standalone/build-linux-x64.sh scripts/standalone/smoke.sh, which completed successfully.bash -nagainst the new scripts to ensure no syntax errors were introduced.yaml.safe_load) but that check failed in this environment becausePyYAMLis not installed, so full YAML schema/CI validation was not executed here.Codex Task