Skip to content

Add macOS targets to standalone release workflow#12

Merged
jooh merged 2 commits intomainfrom
codex/add-mac-os-support
Apr 2, 2026
Merged

Add macOS targets to standalone release workflow#12
jooh merged 2 commits intomainfrom
codex/add-mac-os-support

Conversation

@jooh
Copy link
Copy Markdown
Owner

@jooh jooh commented Apr 2, 2026

Motivation

  • Extend standalone artifact distribution to macOS (x64 and arm64) in addition to existing Linux x64 to support broader release targets.
  • Make the standalone build plumbing target-aware so a single build flow can produce per-platform wrapper artifacts.
  • Ensure checksumming and signing steps are portable across CI runners and explicitly install cosign before keyless signing.

Description

  • Replace the Linux-only job with a matrix job in .github/workflows/standalone-release.yml that builds linux-x64, darwin-x64, and darwin-arm64, exposes TARGET/ARTIFACT env vars, and uploads per-target artifacts.
  • Add scripts/standalone/build.sh to produce a platform-specific wrapper at dist/standalone/devcontainer-<target> and make scripts/standalone/build-linux-x64.sh delegate to it.
  • Use shasum -a 256 for cross-platform checksum creation and add sigstore/cosign-installer@v3.8.1 to the workflow before cosign signing, plus update upload paths and artifact names to use the matrix ARTIFACT.
  • Update documentation files docs/standalone/distribution.md and docs/standalone/prototype.md to reflect macOS target support and the Node SEA-style wrapper approach.

Testing

  • Performed shell syntax checks with bash -n scripts/standalone/build.sh scripts/standalone/build-linux-x64.sh scripts/standalone/smoke.sh, which completed successfully.
  • Verified bash -n against the new scripts to ensure no syntax errors were introduced.
  • Attempted workflow YAML validation with Python (yaml.safe_load) but that check failed in this environment because PyYAML is not installed, so full YAML schema/CI validation was not executed here.

Codex Task

@jooh
Copy link
Copy Markdown
Owner Author

jooh commented Apr 2, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb9d890499

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- target: linux-x64
runner: ubuntu-22.04
- target: darwin-x64
runner: macos-13
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace retired macOS runner label

Using macos-13 here breaks the release workflow on current GitHub-hosted runners: GitHub retired the macos-13 label on December 4, 2025, so this matrix entry now fails to start and causes the standalone job to fail for every tagged release run. This commit introduced that hard-coded label for the darwin-x64 build, so the x64 macOS artifact lane is effectively non-functional until it is moved to a supported Intel label (for example macos-15-intel/macos-14-large) or an arm-compatible strategy.

Useful? React with 👍 / 👎.

@jooh
Copy link
Copy Markdown
Owner Author

jooh commented Apr 2, 2026

@codex fix review suggestion

@chatgpt-codex-connector
Copy link
Copy Markdown

Summary

  • Updated the standalone release workflow matrix to replace the retired Intel macOS runner label for the darwin-x64 target, changing macos-13 to macos-15-intel.
  • Committed the change on the current branch as 9f53680 with message: Use supported Intel macOS runner in standalone release workflow.
  • Created a follow-up PR via make_pr titled “Follow-up: replace retired macOS runner label for standalone darwin-x64 lane”.

Testing

  • git diff -- .github/workflows/standalone-release.yml
  • ⚠️ python - <<'PY'\nimport yaml,sys\np='.github/workflows/standalone-release.yml'\nwith open(p) as f: yaml.safe_load(f)\nprint('yaml ok')\nPY (warning: PyYAML is not installed in this environment)
  • nl -ba .github/workflows/standalone-release.yml | sed -n '12,34p'
  • git rev-parse --short HEAD

View task →

@jooh jooh merged commit efdb05a into main Apr 2, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant