Add new subtables control and replace legacy notes UI#2
Open
jordicompanym wants to merge 2 commits intojosepsanzcamp:masterfrom
Open
Add new subtables control and replace legacy notes UI#2jordicompanym wants to merge 2 commits intojosepsanzcamp:masterfrom
jordicompanym wants to merge 2 commits intojosepsanzcamp:masterfrom
Conversation
Owner
|
Thanks for the PR, I appreciate the contribution. I’ll take some time to review it in detail and see how it could fit into the project. At the moment I’m working on separating widgets behind a clearer specification so they can be added and registered without touching multiple global files. The goal is to make it easier to extend the system and add new components in a more straightforward way. Once I finish that part I’ll look at how your proposal could be integrated with that approach. If you have any questions in the meantime, feel free to ask. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the legacy notes UI with a subtable-based notes control (create/view/edit) and adds inline note editing/search/highlight in form screens.
What changed
Validation