Make template lookup more confident#60
Open
julianrubisch wants to merge 7 commits into
Open
Conversation
…ex into template-lookup
Owner
|
That method is actually looking for the template that rendered the component, not the template that the component renders. It's the differeniate between different component instances |
Contributor
Author
|
Hmmm so I need to approach that differently. Any idea what could work? |
Owner
|
Providing the key manually through My knee-jerk reaction is to just always use second call in the call stack, because that's always going to be what's rendering the component, but I seem to recall trying that initially and running into problems. It might have had something to do with debuggers not playing nicely... Definitely something to check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By trying to get a template matching
self.class.name.underscorefirst.This fixes inline rendered views (i.e., without a top-level view file)