Skip to content

Fixed parameter precedence logic #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xCROv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed parameter precedence logic #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tcgplayer_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,19 @@ def __init__(
)
config_rate_limit = 10

# Fix: Only use constructor parameter if it's not the default value
final_max_requests_per_second = (
max_requests_per_second if max_requests_per_second != 10
else config_rate_limit
)
final_rate_limit_window = (
rate_limit_window if rate_limit_window != 1.0
else config.rate_limit_window
)

self.rate_limiter: RateLimiter = RateLimiter(
max_requests_per_second or config_rate_limit,
rate_limit_window or config.rate_limit_window,
final_max_requests_per_second,
final_rate_limit_window,
)

# Request retry configuration (prioritize passed parameters)
Expand Down Expand Up @@ -161,7 +171,7 @@ def __init__(

logger.info(
f"TCGplayer client initialized with rate limit: "
f"{max_requests_per_second} req/s (TCGplayer maximum: 10 req/s)"
f"{final_max_requests_per_second} req/s (TCGplayer maximum: 10 req/s)"
)
logger.info(
f"Retry configuration: max {max_retries} attempts, base delay {base_delay}s"
Expand Down