fix: JsonField now correctly renders falsy values in list view (#734)#765
Open
SHYXIN wants to merge 2 commits into
Open
fix: JsonField now correctly renders falsy values in list view (#734)#765SHYXIN wants to merge 2 commits into
SHYXIN wants to merge 2 commits into
Conversation
…f#734) The json render function in render.js used `if (data)` which incorrectly treated falsy values (0, false, "", [], {}) as null, displaying them as "-null-". Changed to `if (data != null)` so only actual null/undefined values display as "-null-". Added test to verify API correctly serializes falsy JSON values.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 6848 6870 +22
=========================================
+ Hits 6848 6870 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The json render function used
if (data)which incorrectly treated falsy values (0,false,"",[],{}) as null, displaying them as-null-in the list view.Changes
starlette_admin/statics/js/render.js:67— Changedif (data)toif (data != null)so only actual null/undefined displays as-null-tests/test_views.py— Addedtest_json_field_falsy_valuesto verify API correctly serializes falsy JSON valuesTesting
test_json_field_falsy_values