Allow filtering on enum ListField#781
Open
snow-born wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
– Builds on: #746
Summary
This PR adapts the multiple choice behaviour of
EnumFieldby testing withcontains, so that combinations of options from the enum are available for filtering.Changes
New Features
containsandwithoutto allow filtering of enum-typeListFieldcolumns.Modified Files
starlette_admin/statics/js/list.js— Use the encapsulatedEnumFieldwithin theListField. Add newenumArrayConditionand share code between this and extantenumCondition.starlette_admin/templates/list.html— Bumpv=3tov=4forjs/list.jssrc path.Usage
Filter an enum
ListFieldusing the array operatorscontainsandwithout.Testing
Manual verification of
ListField,EnumFieldand enumListField.