Harden CI: SHA-pin actions, add persist-credentials: false#44
Merged
Conversation
…sions SHA-pin all three GitHub Actions (checkout, setup-ruby, upload-artifact) to their current commit SHAs to prevent supply-chain attacks via tag mutation. Add persist-credentials: false to the checkout step so the GITHUB_TOKEN is not persisted in the git config. Add top-level permissions: contents: read to enforce least-privilege.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkout,ruby/setup-ruby, andactions/upload-artifactto their current commit SHAs to prevent supply-chain attacks via tag mutationpersist-credentials: falseto the checkout step so the GITHUB_TOKEN is not persisted in the local git configpermissions: contents: readto enforce least-privilege on the workflow's GITHUB_TOKENTest plan
bundle exec rspecstill runs and coverage artifact uploads