Changed dump function parameter requirements#320
Open
ABridoux wants to merge 2 commits intojpsim:mainfrom
Open
Changed dump function parameter requirements#320ABridoux wants to merge 2 commits intojpsim:mainfrom
ABridoux wants to merge 2 commits intojpsim:mainfrom
Conversation
The dump functions now require a NodeRepresentable value to be passed rather than Any. This makes the caller responsible for ensuring the provided value can be represented by a node, while default implementations for common types is provided. Also fixed some typos.
jpsim
reviewed
May 24, 2021
Collaborator
|
Hey @ABridoux this change still seems relevant. If you're interested in merging the PR, please rebase/merge and add tests covering the new behavior. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dumpfunctions now require aNodeRepresentablevalue to be passed rather thanAny.Context
Closes #299