Add a way of disabling exponential notation when encoding doubles#374
Open
zeionara wants to merge 5 commits intojpsim:mainfrom
Open
Add a way of disabling exponential notation when encoding doubles#374zeionara wants to merge 5 commits intojpsim:mainfrom
zeionara wants to merge 5 commits intojpsim:mainfrom
Conversation
Owner
|
Very nice, thanks for the PR! I'll take a look shortly. |
Owner
|
Could you please address the failing CI jobs? Missing documentation comments and SwiftLint rule violations. Also CMake updates. |
lynchsft
reviewed
Feb 24, 2025
| public var mappingStyle: Node.Mapping.Style = .any | ||
|
|
||
| /// Set the style for formatting doubles | ||
| public static var doubleFormatStyle: NumberFormatStyle = .scientific |
Collaborator
There was a problem hiding this comment.
A static var is not compatible with Swift 6 language mode. If we refactor this as an instance variable we can revitalize this PR.
lynchsft
requested changes
Feb 24, 2025
Collaborator
lynchsft
left a comment
There was a problem hiding this comment.
A static var is not compatible with Swift 6 language mode. If we refactor this as an instance variable we can revitalize this PR.
|
Any chance to revive this PR? |
lynchsft
requested changes
Apr 2, 2025
Collaborator
lynchsft
left a comment
There was a problem hiding this comment.
Please see comment dated Feb 24.
|
Oh, my mistake, I looked at the previous comment dated Jan 2023 and somehow assumed the next one from Feb was also from 2023 :D. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #279
In current version all doubles are encoded in a scientific notation:
produces:
6.85e+0The proposed change is to add a static option to
Emitter.Optionsclass, so it can be used as follows:which produces the expected result:
6.85YAMLEncoderobject is also supported, as well as numbers with zero fraction part, which are not saved as integers. For example, the following code:generates the expected result:
6.0