Add SMS fallback plugin (initial scaffold) and emit message:fallback hook#2
Draft
jr-everstar wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
message:fallbacktoHookEventand makeMessageService.sendTextemitmessage:fallbackwhen failure matches WhatsApp-registration errors viaisWhatsAppRegistrationError.SmsFallbackPlugininsrc/plugins/extensions/sms-fallback.plugin.tsthat registers onmessage:failed, logs fallback intents, and exposes a small config schema (enabled,provider,apiKey,from).sms-fallbackbuilt-in plugin inPluginLoaderService.loadBuiltInPluginsand add documentation (docs/23-sms-fallback-plugin.md) plus README entries pointing to the new docs.HookManager.getRegisteredHooks, minor type/formatting adjustments inengine.factory.ts,session.service.ts(remove unnecessary casts when dispatching events),docker.service.tsPortBindingsreduction, and a signature cast removal inbulk-message.service.ts.src/modules/message/message.service.spec.tsto assert themessage:fallbackhook is emitted when target is not a WhatsApp account.Testing
src/modules/message/message.service.spec.tsto cover fallback emission and existing send flows.npm testand all tests completed successfully.Codex Task