Set scale of objects which have units of "scene"

[joshnice]

Allow an object in the threebox world which is using units of "scene", to use the setScale function. Provided example as well.

[jscastro76]

Hi, @joshnice
Thanks for contributing!
I haven't had time yet to test all the changes but at first sight I see a mistake options.scale = this.scale; must be set always, not only in the else part. The reason is basically to keep that value updated always to the latest. This is needed to avoid any issue if you clone an object, otherwise the new object won't be able to restore with the latest value.

options.scale = this.scale;

If you change that, I'm happy to approve and welcome you as contributor!

[joshnice]

Hi @jscastro76,
I have made the changes you suggested and thanks for the explanation of why it needed to be changed!
I also found an issue that when the object is loaded with units of meters the setScale function does not work (this is happening in the master), I did not know if you were aware of this or not. However when I am using Threebox I load the models in with the units of scene, so this does not affect me.

[jscastro76]

Hi @jscastro76, I have made the changes you suggested and thanks for the explanation of why it needed to be changed! I also found an issue that when the object is loaded with units of meters the setScale function does not work (this is happening in the master), I did not know if you were aware of this or not. However when I am using Threebox I load the models in with the units of scene, so this does not affect me.

setScale should work as it's heavily used when the model has fix zoom property... can you elaborate or show me that bug in any example?

[joshnice]

Sorry I was mistaken, I had not set the fixedZoom property as true. So there is no issue with the units being meters and setting the scale.