tb must set global var (fix)#423
Open
iimrudy wants to merge 7 commits intojscastro76:masterfrom
Open
Conversation
|
Looks like your auto-formatter has changed a lot of small stuff, like replacing " with '. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've managed to remove the must set global var everywhere because i was having some trouble with it.
I've also did some testing and everything seems to be working fine.
I've also added some types for typescript into the index.d.ts. idk if they are working right or what... let me know if i have to fix something :)
any change to get the new release of threebox? it would be very usefull to me (and i think to some other users that already reported this bug :) )
Thanks.