Fix I/O conflicts when running OpenAPI tests#2013
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2013 +/- ##
=======================================
Coverage 92.12% 92.12%
=======================================
Files 438 438
Lines 15044 15044
Branches 2488 2488
=======================================
Hits 13859 13859
Misses 731 731
Partials 454 454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bkoelman
force-pushed
the
refactor-tests
branch
3 times, most recently
from
f5abb76 to
7d11941
Compare
…n in tests; fail test if file on disk changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project OpenApiTests writes
swagger.g.jsonfiles when tests are run. They are consumed by end-to-end tests to generate typed clients. Because OpenApiTests targets multiple frameworks, writing such files occasionally results in I/O conflicts when tests run in parallel. This PR fixes that by only writing them fornet10.0in a dedicated subdirectory. Additionally, it fails these tests when the file on disk differs from the one generated by the test, forcing PRs to commit the changed files to achieve a green build.The other commits simplify some service registration calls and rename some test methods.
QUALITY CHECKLIST