remove conditional $id tests from draft 6#562
Merged
Conversation
Member
|
I have to stare at these again tomorrow but I suspect they're still salvageable without using if/then/else -- those are being used out of convenience but I don't think they're part of the purpose of the test -- probably using oneOf or allOf would work |
Member
Author
|
That's fine, but I just wanted to resolve these being incorrect. My build is failing because of these. I can try to rework them in terms of |
Member
|
It looks like the linter that should catch this isn't running properly for draft 2019 :/ I'll look at why tomorrow. |
Julian
added a commit
that referenced
this pull request
Jun 28, 2022
It was previously skipping validating newer drafts :/ Refs: #562
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/383/files#r907940838
These tests use
if/then/elsewhich weren't introduced to draft 7. We need to remove these from draft 6.