Fix: remove resize listener on unmount in Sidebar (#2241)#2262
Open
severe77 wants to merge 1 commit intojson-schema-org:mainfrom
Open
Fix: remove resize listener on unmount in Sidebar (#2241)#2262severe77 wants to merge 1 commit intojson-schema-org:mainfrom
severe77 wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 663 663
Branches 205 205
=========================================
Hits 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Issue Number:
Screenshots/videos:
N/A – internal lifecycle fix, no visible UI changes.
If relevant, did you update the documentation?
No documentation changes required.
Summary
This PR fixes a resize event listener accumulation issue in
components/Sidebar.tsx.Previously, the
useEffecthook added awindow.resizelistener using an anonymous function and did not remove it on unmount. When navigating between pages that mount/unmount the Sidebar, multiple resize listeners accumulated over time. This caused redundant executions on resize and a small memory leak.The fix:
handleResizefunctionwindow.removeEventListenerNo other logic or behavior was changed.
Notes
resizelistener remains attached after repeated navigation.Does this PR introduce a breaking change?
No.
Checklist