fix: handle implicit and collapsed reference links in markdown #2265#2269
Open
h30s wants to merge 3 commits intojson-schema-org:mainfrom
Open
fix: handle implicit and collapsed reference links in markdown #2265#2269h30s wants to merge 3 commits intojson-schema-org:mainfrom
h30s wants to merge 3 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
============================================
- Coverage 100.00% 85.15% -14.85%
============================================
Files 30 34 +4
Lines 663 822 +159
Branches 205 246 +41
============================================
+ Hits 663 700 +37
- Misses 0 122 +122 🚀 New features to boost your workflow:
|
Author
|
@vtushar06 @Utkarsh-123github Please take a look whenever you have time. The PR is ready from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
N/A (Logic fix verified with Cypress component tests)
If relevant, did you update the documentation?
No
Summary
Fixed
transformMarkdownLinksregex to correctly parse implicit[text][]and collapsed[text]reference links. It also now supports the optional space between brackets like[text] [id], making it fully spec-compliant. Added Cypress tests to verify all variants.Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.