Skip to content

fix: blog pagination reset - implement URL parameter persistence #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waygeance wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: blog pagination reset - implement URL parameter persistence #2291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
486406f
fix: blog pagination reset - implement URL parameter persistence
waygeance Feb 27, 2026
9122d95
Change indentation of index.page.tsx
waygeance Mar 3, 2026
0cd8cbe
fix: resolve linting errors in blog index page
Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 57 additions & 19 deletions pages/blog/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const getCategories = (frontmatter: any): blogCategories[] => {
return Array.isArray(cat) ? cat : [cat];
};

export async function getStaticProps({ query }: { query: any }) {
export async function getStaticProps() {
const files = fs.readdirSync(PATH);
const blogPosts = files
.filter((file) => file.substr(-3) === '.md')
Expand All @@ -55,12 +55,9 @@ export async function getStaticProps({ query }: { query: any }) {

await generateRssFeed(blogPosts);

const filterTag: string = query?.type || 'All';

return {
props: {
blogPosts,
filterTag,
},
};
}
Expand All @@ -79,20 +76,30 @@ function isValidCategory(category: any): category is blogCategories {

export default function StaticMarkdownPage({
blogPosts,
filterTag,
}: {
blogPosts: any[];
filterTag: any;
}) {
const router = useRouter();

// Initialize the filter as an array. If "All" or not specified, we show all posts.
const initialFilters =
filterTag && filterTag !== 'All'
? filterTag.split(',').filter(isValidCategory)
router.query.type && router.query.type !== 'All'
? (router.query.type as string).split(',').filter(isValidCategory)
: ['All'];

const [currentFilterTags, setCurrentFilterTags] =
useState<blogCategories[]>(initialFilters);
const [currentFilterTags, setCurrentFilterTags] = useState<blogCategories[]>(
initialFilters as blogCategories[],
);

const [currentPage, setCurrentPage] = useState(1);

// Set client-side flag and initialize from URL
useEffect(() => {
const urlParams = new URLSearchParams(window.location.search);
const pageParam = urlParams.get('page');
const initialPage = pageParam ? Math.max(1, parseInt(pageParam, 10)) : 1;
setCurrentPage(initialPage);
}, []);

// When the router query changes, update the filters.
useEffect(() => {
Expand All @@ -101,18 +108,26 @@ export default function StaticMarkdownPage({
const tags = (typeof query.type === 'string' ? query.type : '')
.split(',')
.filter(isValidCategory);
setCurrentFilterTags(tags.length ? tags : ['All']);
setCurrentFilterTags(tags.length ? (tags as blogCategories[]) : ['All']);
setCurrentPage(1);
}
// Update page from URL query parameter
if (query.page) {
const page = Math.max(
1,
parseInt(Array.isArray(query.page) ? query.page[0] : query.page, 10),
);
setCurrentPage(page);
}
}, [router.query]);

useEffect(() => {
const tags =
filterTag && filterTag !== 'All'
? filterTag.split(',').filter(isValidCategory)
router.query.type && router.query.type !== 'All'
? (router.query.type as string).split(',').filter(isValidCategory)
: ['All'];
setCurrentFilterTags(tags);
}, [filterTag]);
setCurrentFilterTags(tags as blogCategories[]);
}, [router.query.type]);

const toggleCategory = (tag: blogCategories) => {
let newTags: blogCategories[] = [];
Expand All @@ -132,7 +147,8 @@ export default function StaticMarkdownPage({
newTags = ['All'];
}
}
setCurrentFilterTags(newTags);
setCurrentFilterTags(newTags as blogCategories[]);
setCurrentPage(1); // Reset to page 1 when filter changes
if (newTags.includes('All')) {
history.replaceState(null, '', '/blog');
} else {
Expand Down Expand Up @@ -193,7 +209,6 @@ export default function StaticMarkdownPage({

// pagination implement
const POSTS_PER_PAGE = 10;
const [currentPage, setCurrentPage] = useState(1);

const totalPages = Math.ceil(sortedFilteredPosts.length / POSTS_PER_PAGE);

Expand All @@ -211,6 +226,29 @@ export default function StaticMarkdownPage({
}
}, [currentPage]);

// Function to update URL with current page and filters
const updateUrl = (page: number, tags: blogCategories[]) => {
const params = new URLSearchParams();
if (page > 1) params.set('page', page.toString());
if (tags.length > 0 && !tags.includes('All')) {
params.set('type', tags.join(','));
}
const queryString = params.toString();
const newUrl = queryString ? `/blog?${queryString}` : '/blog';
history.replaceState(null, '', newUrl);
};

// Update URL when page or filters change
useEffect(() => {
updateUrl(currentPage, currentFilterTags);
}, [currentPage, currentFilterTags]);

const handlePageChange = (newPage: number) => {
if (newPage >= 1 && newPage <= totalPages) {
setCurrentPage(newPage);
}
};

const currentPagePosts = sortedFilteredPosts.slice(
(currentPage - 1) * POSTS_PER_PAGE,
currentPage * POSTS_PER_PAGE,
Expand Down Expand Up @@ -465,7 +503,7 @@ export default function StaticMarkdownPage({
: 'bg-blue-600 text-white hover:bg-blue-700'
}`}
disabled={currentPage === 1}
onClick={() => setCurrentPage((p) => p - 1)}
onClick={() => handlePageChange(currentPage - 1)}
>
Previous
</button>
Expand All @@ -479,7 +517,7 @@ export default function StaticMarkdownPage({
: 'bg-blue-600 text-white hover:bg-blue-700'
}`}
disabled={currentPage === totalPages}
onClick={() => setCurrentPage((p) => p + 1)}
onClick={() => handlePageChange(currentPage + 1)}
>
Next
</button>
Expand Down
Loading