fix: remove anchor hash#2351
Closed
Divyansh200102 wants to merge 1 commit intojson-schema-org:mainfrom
Closed
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hi @Divyansh200102 Also please refrain from opening any PR before getting assigned. |
github-project-automation
bot
moved this from Ready to review
to Done
in PR - Triage Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix.
Issue Number:
Screenshots/videos:
After(navigates directly to the top of the page)
Summary
The markdown links contained an anchor (
#hyper-schema-vocabulary) that disrupted the standard scroll behavior. I removed this anchor from the affected links in bothpages/specification/json-hyper-schema/_index.mdandpages/specification.mdso the router now correctly loads the target page at the top header.Does this PR introduce a breaking change?
No.
Checklist