Skip to content

Fix #2341: clicking section header scrolls to top and highlights all headers#2352

Open
Surajiitmjnu wants to merge 4 commits intojson-schema-org:mainfrom
Surajiitmjnu:#2398
Open

Fix #2341: clicking section header scrolls to top and highlights all headers#2352
Surajiitmjnu wants to merge 4 commits intojson-schema-org:mainfrom
Surajiitmjnu:#2398

Conversation

@Surajiitmjnu
Copy link
Copy Markdown
Contributor

@Surajiitmjnu Surajiitmjnu commented Mar 18, 2026

What kind of change does this PR introduce?
Bugfix

Issue Number:

Screenshots/videos:

suraj_json_new.mp4

If relevant, did you update the documentation?
No

Summary
This PR fixes the issue where clicking on a section header or navigating through the Table of Contents scrolls the page incorrectly and does not properly highlight the active section.

The fix ensures that:

  • The page scrolls to the correct section instead of the top.
  • Only the active section header is highlighted, instead of all headers being highlighted.

This improves navigation clarity and overall user experience.

Does this PR introduce a breaking change?
No

Checklist

  • Read, understood, and followed the contributing guidelines.

@Surajiitmjnu Surajiitmjnu requested a review from a team as a code owner March 18, 2026 07:02
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Mar 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 9e723a2

@Surajiitmjnu Surajiitmjnu changed the title #2398 Fix #2341: clicking section header scrolls to top and highlights all headers Mar 18, 2026
@Surajiitmjnu
Copy link
Copy Markdown
Contributor Author

Hi @idanidan29 sir,
Could you please review this PR and let me know if any further changes are required?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dbfaf31) to head (9e723a2).
⚠️ Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       672   +39     
  Branches       196       211   +15     
=========================================
+ Hits           633       672   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

🐛 Bug:Clicking section header scrolls to top and highlights all headers

1 participant