fix(pages): prevent writeOnly keyword links from sticking to bottom of viewport#2364
Open
student-ankitpandit wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix (fix
writeOnlykeyword to not to stick at the bottom of the page and flow naturally within the page content)Issue Number:
Closes #2361
Screenshots/videos:
Summary
The links under the
writeOnlykeyword section on the JSON Schema. Keywords reference page were visually pinned/fixed to the bottom of the viewport, overlapping the "GO BACK" / "UP NEXT" navigation buttons.Fixed by adding
mb-4(margin-bottom) to the keyword section wrapper div in [index.page.tsx], ensuring consistent spacing for all keyword sections, including the last one in the list.The
writeOnlysection is the last item in the list. Withoutmb-4, there was no bottom margin, causing the links to appear squished right up against the GO BACK/UP NEXT buttons — making it look like they were "pinned" to the bottom.Adding
mb-4gave it proper spacing below, so it now looks consistent with other sections.The links now flow naturally within the page content, consistent with other keyword sections like
unevaluatedItemsanduniqueItems.Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.