fix(pages): add missing code-of-conduct markdown file#2370
Closed
student-ankitpandit wants to merge 1 commit intojson-schema-org:mainfrom
Closed
fix(pages): add missing code-of-conduct markdown file#2370student-ankitpandit wants to merge 1 commit intojson-schema-org:mainfrom
student-ankitpandit wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Closing this PR, as the issue is not reproducible. |
github-project-automation
bot
moved this from Ready to review
to Done
in PR - Triage Group
Author
|
Right, I also added the all 12 submodules but the issue is still there locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix (added _index.md file to render coc correctly)
Issue Number:
Closes #2369
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
This PR fixes the Code of Conduct page that was failing to load due to a missing markdown file. The getStaticProps() function in
index.page.tsxwas trying to read_index.mdwhich didn't exist. This PR adds the missing file with the official Code of Conduct content from the JSON Schema GitHub repository.Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.