Skip to content

fix(pages): broken coc panel link#2371

Closed
student-ankitpandit wants to merge 2 commits intojson-schema-org:mainfrom
student-ankitpandit:fix/broken-coc-panel-link
Closed

fix(pages): broken coc panel link#2371
student-ankitpandit wants to merge 2 commits intojson-schema-org:mainfrom
student-ankitpandit:fix/broken-coc-panel-link

Conversation

@student-ankitpandit
Copy link
Copy Markdown

@student-ankitpandit student-ankitpandit commented Mar 28, 2026

What kind of change does this PR introduce?

Bugfix (added the valid urls for conduct and governance)

Issue Number:

Closes #2345

Screenshots/videos:

image image

If relevant, did you update the documentation?

No

Summary

The link to the OpenJS Code of Conduct Panel (CoCP) in the Code of Conduct page was pointing to conduct/FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md in the openjs-foundation/cross-project-council repository, which no longer exists and returns a 404 error. Updated the link to point to the correct existing file conduct/COC_POLICY.md which contains the relevant CoC Panel information.

Note: This fix was accidentally committed on top of a different issue's branch (fix/add-missing-coc-_index-markdown) instead of a fresh branch from main. A cherry-pick to isolate it caused a conflict since _index.md doesn't exist on main yet. The fix is included in that branch's PR and documented here separately for transparency.

Does this PR introduce a breaking change?

No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@github-actions
Copy link
Copy Markdown

Hi @student-ankitpandit! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview e7a44a2

@student-ankitpandit student-ankitpandit changed the title Fix/broken coc panel link fix(pages): broken coc panel link Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5ca1483) to head (e7a44a2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2371   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          672       672           
  Branches       211       211           
=========================================
  Hits           672       672           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Copy Markdown
Member

Hi @student-ankitpandit
The changes you made here in this file are not correct.
The required changes to fix this issue is just 2 line fix, by adding the correct link.

Also, I'll be closing this PR because the issue wasn't assigned to you and was still in triage.
Please follow the contribution guidelines and wait to get yourself assigned to an issue before raising PR.
Thank you!

@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Mar 29, 2026
@student-ankitpandit
Copy link
Copy Markdown
Author

I know the fix is just about 2 lines but I did a small mistake. This fix was accidentally committed on top of a different issue's branch (fix/add-missing-coc-_index-markdown) instead of a fresh branch from main. A cherry-pick to isolate it caused a conflict since _index.md doesn't exist on main yet. The fix is included in that branch's PR and documented here separately for transparency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Broken link pointing to non-existent path in cross-project-council repo

2 participants