fix(pages): broken coc panel link#2371
fix(pages): broken coc panel link#2371student-ankitpandit wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
|
Hi @student-ankitpandit! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @student-ankitpandit Also, I'll be closing this PR because the issue wasn't assigned to you and was still in triage. |
|
I know the fix is just about 2 lines but I did a small mistake. This fix was accidentally committed on top of a different issue's branch (fix/add-missing-coc-_index-markdown) instead of a fresh branch from main. A cherry-pick to isolate it caused a conflict since _index.md doesn't exist on main yet. The fix is included in that branch's PR and documented here separately for transparency. |
What kind of change does this PR introduce?
Bugfix (added the valid urls for conduct and governance)
Issue Number:
Closes #2345
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
The link to the OpenJS Code of Conduct Panel (CoCP) in the Code of Conduct page was pointing to conduct/FOUNDATION_CODE_OF_CONDUCT_REQUIREMENTS.md in the openjs-foundation/cross-project-council repository, which no longer exists and returns a 404 error. Updated the link to point to the correct existing file conduct/COC_POLICY.md which contains the relevant CoC Panel information.
Note: This fix was accidentally committed on top of a different issue's branch (fix/add-missing-coc-_index-markdown) instead of a fresh branch from main. A cherry-pick to isolate it caused a conflict since _index.md doesn't exist on main yet. The fix is included in that branch's PR and documented here separately for transparency.
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.