You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What kind of change does this PR introduce?
Bugfix Issue Number:
Closes🐛 Bug:Clicking on "Draft 2019-09" in Introduction section leads to 404 Page Not Found #2358 Screenshots/videos:
N/A - Links were resolving to incorrect URLs (/draft/draft/2019-09/... instead of /draft/2019-09/...) If relevant, did you update the documentation?
N/A Summary
Fixed broken navigation links in the draft pages that were causing 404 errors. The issue was caused by incorrect relative paths in markdown files:
pages/draft/2019-09/index.md and pages/draft/2020-12/index.md had links like ../draft/2019-09/release-notes which resolved to /draft/draft/2019-09/release-notes (doubled draft segment). Changed to ./release-notes.
pages/draft/2019-09/release-notes.md had relative paths like ../../draft/2019-09/json-schema-core.html which resolved incorrectly. Changed to absolute URLs (https://json-schema.org/draft/2019-09/...) for external specification links. Does this PR introduce a breaking change?
No
Hi, @kedar49 please make sure to get the issue assigned first before you proceed with the PR. This will help the maintainers to speed up the process as they have been busy on their own work most of the times. Thank you:)
Hi, @kedar49 please make sure to get the issue assigned first before you proceed with the PR. This will help the maintainers to speed up the process as they have been busy on their own work most of the times. Thank you:)
Yes , I'll keep that in mind for next contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
N/A - Links were resolving to incorrect URLs (
/draft/draft/2019-09/...instead of/draft/2019-09/...)If relevant, did you update the documentation?
N/A
Summary
Fixed broken navigation links in the draft pages that were causing 404 errors. The issue was caused by incorrect relative paths in markdown files:
pages/draft/2019-09/index.mdandpages/draft/2020-12/index.mdhad links like../draft/2019-09/release-noteswhich resolved to/draft/draft/2019-09/release-notes(doubleddraftsegment). Changed to./release-notes.pages/draft/2019-09/release-notes.mdhad relative paths like../../draft/2019-09/json-schema-core.htmlwhich resolved incorrectly. Changed to absolute URLs (https://json-schema.org/draft/2019-09/...) for external specification links.Does this PR introduce a breaking change?
No