Skip to content

fix: correct relative links causing 404 on draft pages, Fixes #2358#2375

Closed
kedar49 wants to merge 1 commit intojson-schema-org:mainfrom
kedar49:fix/draft-2019-09-404-navigation
Closed

fix: correct relative links causing 404 on draft pages, Fixes #2358#2375
kedar49 wants to merge 1 commit intojson-schema-org:mainfrom
kedar49:fix/draft-2019-09-404-navigation

Conversation

@kedar49
Copy link
Copy Markdown

@kedar49 kedar49 commented Mar 31, 2026

What kind of change does this PR introduce?
Bugfix
Issue Number:

  1. pages/draft/2019-09/index.md and pages/draft/2020-12/index.md had links like ../draft/2019-09/release-notes which resolved to /draft/draft/2019-09/release-notes (doubled draft segment). Changed to ./release-notes.
  2. pages/draft/2019-09/release-notes.md had relative paths like ../../draft/2019-09/json-schema-core.html which resolved incorrectly. Changed to absolute URLs (https://json-schema.org/draft/2019-09/...) for external specification links.
    Does this PR introduce a breaking change?
    No

@kedar49 kedar49 requested a review from a team as a code owner March 31, 2026 15:11
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 8f16fcd

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5ca1483) to head (8f16fcd).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          672       672           
  Branches       211       211           
=========================================
  Hits           672       672           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Siddhartha20242
Copy link
Copy Markdown
Contributor

Hi, @kedar49 please make sure to get the issue assigned first before you proceed with the PR. This will help the maintainers to speed up the process as they have been busy on their own work most of the times. Thank you:)

@kedar49
Copy link
Copy Markdown
Author

kedar49 commented Apr 2, 2026

Hi, @kedar49 please make sure to get the issue assigned first before you proceed with the PR. This will help the maintainers to speed up the process as they have been busy on their own work most of the times. Thank you:)

Yes , I'll keep that in mind for next contributions

@jdesrosiers
Copy link
Copy Markdown
Member

You weren't assigned and this doesn't even fix the bug reported in the issue.

@jdesrosiers jdesrosiers closed this Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 Bug:Clicking on "Draft 2019-09" in Introduction section leads to 404 Page Not Found

3 participants