perf(transaction): cache serialized records to avoid double serialization#10
Merged
perf(transaction): cache serialized records to avoid double serialization#10
Conversation
…tion - Cache serialized records in Transaction._buffer_serialized during put() and reuse at commit() time, eliminating redundant serialization - Remove unused start_mtime parameter from _commit_transaction_buffer - Add key length validation to Transaction.delete() and Table.delete() for consistency with put() methods Extract validate_key_length() helper to _keys.py to reduce code duplication. Add tests for key length validation in delete operations.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #10 will not alter performanceComparing Summary
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transaction._buffer_serializedduringput()and reuse atcommit()time, eliminating redundant serializationstart_mtimeparameter from_commit_transaction_bufferTransaction.delete()andTable.delete()for consistency withput()methodsvalidate_key_length()helper to_keys.pyto reduce code duplicationTest plan