add sourcemaps support for @if directives.#127
Open
Izhaki wants to merge 1 commit intojsoverson:masterfrom
Izhaki:master
Open
add sourcemaps support for @if directives.#127Izhaki wants to merge 1 commit intojsoverson:masterfrom Izhaki:master
Izhaki wants to merge 1 commit intojsoverson:masterfrom
Izhaki:master
Conversation
Author
|
Related to #59 |
Author
|
Whilst this only implements @if directive, I guess a non-negligible part of the user base will benefit from this change. So possibly merge and iterate later, rather than waiting for the full support. |
1 similar comment
Author
|
Hmmm... the build fails on non-code related error - ERROR: npm is known not to run on Node.js v0.12.18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the process was removing lines from scripts, sourcemaps (and coverage reports) line mapping was faulty.
With this change, removed content (and directives) is replaced with empty lines, maintaining correct line mapping.