Open
Conversation
added 2 commits
July 2, 2015 13:22
Jade allows //- for comments, which didn't work with the js rules.
Contributor
|
Nice work! It'll take time for me to merge this because I'll have to implement tests for the introduced functionality. You could help me with this if you want to. |
Contributor
|
Just one thing. This pull request includes package.json change that should not be merged. |
|
@gittycat |
Contributor
|
@shenqihui it's three years old and inactive, so surely nobody will be mad at you. When you're at it, remember that Jade was renamed to pug. |
Author
|
Done, pull request is here #134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jade has two comment styles:
//- for comments that are to be stripped before generation to html
// for comments that get converted into in the html.
The //- style comment is important in Jade and it requires the changes to the js regex that I've made.