Fix: End of JavaScript comments are not parsed#83
Open
anseki wants to merge 3 commits intojsoverson:masterfrom
Open
Fix: End of JavaScript comments are not parsed#83anseki wants to merge 3 commits intojsoverson:masterfrom
anseki wants to merge 3 commits intojsoverson:masterfrom
Conversation
Author
|
I renamed vars because those are not good naming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
#77 (comment)
In JavaScript code, that regexp stops reading immediately it found
*without checking*/or end of line, etc..Because that regexp accepts these as the end of the directive:
***/That regexp accepts "Nothing". And
*as the parameters is not accepted.For example:
Result:
foo* 1024 > MEM */ BIG barThis PR fixes this bug, and puts common patterns into the variables.