8: Dart build runner integration by f1sh1918 · Pull Request #9 · jtmcdole/protofu

f1sh1918 · 2026-04-13T13:00:03Z

Fixes #8

Proposed Changes

build_runner integration (lib/builder.dart, lib/builder_impl.dart, build.yaml) — Implements the Builder interface. When build_runner detects .proto files under proto/, it invokes ProtofuBuilder to run protoc and write the generated .pb.dart files into lib/proto/. Setup (downloading protoc, resolving/compiling the plugin) is shared across all builder instances via a static future to avoid redundant work.
Plugin resolution from pubspec (lib/plugin_from_pubspec.dart) — Can locate protoc_plugin from the project's package_config and optionally AOT-compile it to a native executable (cached under .dart_tool/build/protofu/plugin/pubspec/), which is faster than using dart run each time.
ARM architecture support (lib/download_tools.dart) — downloadProtoc now detects ARM vs x86-64 on macOS, Linux, and Windows and downloads the correct binary (e.g., osx-aarch_64 for Apple Silicon).
Updated pubspec.yaml — Adds build: ^4.0.0 and package_config: ^2.1.0 dependencies; bumps min SDK to >=3.7.0.
Tests pass
Appropriate changes to README are included in PR

…lugin

google-cla · 2026-04-13T13:00:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

f1sh1918 · 2026-04-13T13:06:13Z

i can remove all idea files if you want!

jtmcdole

Lets remove the .idea folders from the reppo and just put them in .gitignore

jtmcdole · 2026-04-18T15:21:48Z

+import 'package:build/build.dart';
+import 'package:protofu/builder_impl.dart';
+
+Builder getBuilder(BuilderOptions options) => ProtofuBuilder(options);


add public dart doc for public members.

jtmcdole · 2026-04-18T15:22:45Z

Move to lib/src/ unless you want people importing _impl.dart files.

jtmcdole · 2026-04-18T15:23:05Z

+import 'package:protofu/paths.dart';
+import 'package:protofu/plugin_from_pubspec.dart';
+
+class ProtofuBuilder implements Builder {


Add public dart doc for all public classes, members, functions, etc.

jtmcdole · 2026-04-18T15:25:28Z

+import 'package:protofu/paths.dart';
+import 'package:protofu/plugin_from_pubspec.dart';
+
+class ProtofuBuilder implements Builder {


Make this a final class and we never have to worry about others extending or implementing it.

jtmcdole · 2026-04-18T15:27:31Z

API features are added; bump the minor version to 1.3.0
Also update the changelog.

jtmcdole · 2026-04-18T15:30:55Z

+# ProtoFu-Builder
+This is a fork of https://github.com/jtmcdole/protofu
+The ProtoFu builder can be used within a flutter/dart build runner of your project.
+


Ah, but its not a fork anymore!

jtmcdole

--- gemini review summary (forgot to switch to agentfu :(

jtmcdole · 2026-04-18T15:50:15Z

+  // protoc --plugin expects an executable; `dart run <script>` works on all
+  // platforms when passed as the plugin path if Dart is on PATH.
+  // Return the script path directly — callers should prefer precompile: true.
+  return p.join(pluginRoot, 'bin', 'protoc_plugin.dart');


[HIGH] Returning a '.dart' file path directly will likely fail as 'protoc' expects an executable to run the plugin. While the comment mentions 'dart run', the code returns just the script path. If precompilation is not used, you should probably return a wrapper script or ensure the caller handles this correctly (though 'protoc' doesn't easily support arguments in the plugin path).

jtmcdole · 2026-04-18T15:50:21Z

 import 'package:protofu/spinner.dart';
 import 'package:protofu/unzip.dart';

+bool _isArm() {


[LOW] Using 'PROCESSOR_ARCHITECTURE' for ARM detection on Windows can be unreliable if the Dart process is running under emulation (e.g. x86_64 emulation on ARM64). Consider using 'Platform.version' or checking 'PROCESSOR_ARCHITEW6432' as well.

Windows ARM detection now also checks PROCESSOR_ARCHITEW6432, which holds the native architecture when a 32-bit process runs under WOW64 emulation.

Actually i would recommended never working with protobuf on windows in general 🙃

jtmcdole

📋 Review Summary

This PR successfully integrates 'protofu' with the Dart 'build_runner', enabling automated protobuf compilation. It also adds support for ARM architectures and allows resolving the 'protoc_plugin' from the project's dependencies, which is a great improvement for developer experience.

🔍 General Feedback

The use of a static future for setup in the builder is a good performance optimization to avoid redundant tool downloads.
Consider adding unit tests for the new builder implementation and the ARM detection logic to ensure long-term stability across platforms.
The 'build_extensions' in 'build.yaml' are currently hardcoded, which might lead to confusion if users override 'root_dir' or 'out_dir' in the builder options

f1sh1918 · 2026-04-27T07:36:51Z

Thx for your review @jtmcdole
I will work on it next week!

f1sh1918 · 2026-04-28T13:20:32Z

Okay i came to it way earlier than expected.
I hope i addressed all your concerns.

jtmcdole · 2026-06-03T15:11:20Z

Okay i came to it way earlier than expected. I hope i addressed all your concerns.

Did you push any changes?

f1sh1918 · 2026-06-03T16:08:38Z

Okay i came to it way earlier than expected. I hope i addressed all your concerns.

Did you push any changes?

Oh dear I pushed it to the wrong branch, since i had another one for our internal fork, we currently use.
I cherry-picked the commits from there, but will recheck tommorow if everything is fine and resolved since i did this couple of time ago.

…) or .bat file (Windows) instead of returning a raw .dart path that protoc can't execute.

f1sh1918 · 2026-06-04T07:57:57Z

Okay i came to it way earlier than expected. I hope i addressed all your concerns.

Did you push any changes?

Oh dear I pushed it to the wrong branch, since i had another one for our internal fork, we currently use. I cherry-picked the commits from there, but will recheck tommorow if everything is fine and resolved since i did this couple of time ago.

Okay should be fine now

f1sh1918 added 8 commits April 13, 2026 14:55

8: bumped up sdk and build, use package_config to locate protoc_p…

3980857

…lugin

8: enhance architecture detection

e028f16

8: declare protofu as a build_runner builder, add factory function

21a7374

8: implement build_runner integration

a667d08

8: add ability to use a pinned protoc_plugin version

e9fec99

8: add idea files and gitignore

00ea8a6

8: add usage instructions

079f981

8: fix plugin_from_pubspec.dart

587cfef

f1sh1918 added 2 commits April 13, 2026 15:04

8: minor fixes, enable windows environments, update README.md

171ca3b

8: add dart sdk for intelliJ

4d38fe7

f1sh1918 force-pushed the 8-dart-build-runner-integration branch from 4b841df to 4d38fe7 Compare April 13, 2026 13:05

jtmcdole requested changes Apr 18, 2026

View reviewed changes

jtmcdole reviewed Apr 18, 2026

View reviewed changes

Comment thread lib/src/builder_impl.dart

jtmcdole reviewed Apr 18, 2026

View reviewed changes

f1sh1918 requested a review from jtmcdole April 28, 2026 13:21

f1sh1918 added 6 commits June 3, 2026 18:19

8: update readme

af1b9d7

8: add .idea to gitignore

4aedcc2

8: add dartdoc, add final

4b3666e

8: update version and changelog

dfb9b3c

8: improve windows arm detection

a960181

8: _dartRunWrapper now writes an actual executable shell script (Unix…

8179d9e

…) or .bat file (Windows) instead of returning a raw .dart path that protoc can't execute.

8: improve build.yaml documentation

602b74b

Conversation

f1sh1918 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

google-cla Bot commented Apr 13, 2026

Uh oh!

f1sh1918 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtmcdole left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtmcdole left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

f1sh1918 commented Apr 27, 2026

Uh oh!

f1sh1918 commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtmcdole commented Jun 3, 2026

Uh oh!

f1sh1918 commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

f1sh1918 commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

f1sh1918 commented Apr 13, 2026 •

edited

Loading

f1sh1918 commented Apr 13, 2026 •

edited

Loading

jtmcdole left a comment •

edited

Loading

jtmcdole left a comment •

edited

Loading

f1sh1918 commented Apr 28, 2026 •

edited

Loading

f1sh1918 commented Jun 3, 2026 •

edited

Loading