🎨 Palette: Added missing ARIA labels to icon-only buttons for accessibility#17
🎨 Palette: Added missing ARIA labels to icon-only buttons for accessibility#17julesklord wants to merge 1 commit into
Conversation
…bility 💡 What: Added missing `aria-label` attributes to icon-only buttons (like modal close buttons, preview close buttons, and view file source buttons) in `src/App.jsx`. 🎯 Why: Without these labels, screen reader users and those navigating by keyboard rely on the icon alone (or an 'x' character), which can be inaccessible. Adding clear descriptions makes the UI more inclusive. This only targeted icon-only buttons, preventing any regressions on buttons that already had visible text. 📸 Before/After: Visual changes are none, but screen readers will now announce the button's purpose instead of generic "button". ♿ Accessibility: Increased accessibility for users requiring assistive technologies. Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…bility (#17) Merged PR #17 with conflict resolution against #15: - Applied aria-label for view-file-btn buttons (8 instances) - Preserved descriptive aria-labels from #15 for modal close buttons - Combined learnings in .Jules/palette.md - Resolved: PR #17 originally added generic 'Close modal' labels which conflicted with PR #15's more descriptive labels (e.g., 'Close export dialog')
1 participant
🎨 Palette: Added missing ARIA labels to icon-only buttons for accessibility
💡 What: Added missing
aria-labelattributes to icon-only buttons (like modal close buttons, preview close buttons, and view file source buttons) insrc/App.jsx.🎯 Why: Without these labels, screen reader users and those navigating by keyboard rely on the icon alone (or an 'x' character), which can be inaccessible. Adding clear descriptions makes the UI more inclusive. This only targeted icon-only buttons, preventing any regressions on buttons that already had visible text.
📸 Before/After: Visual changes are none, but screen readers will now announce the button's purpose instead of generic "button".
♿ Accessibility: Increased accessibility for users requiring assistive technologies.
PR created automatically by Jules for task 14913925306037986978 started by @julesklord