This repository was archived by the owner on Jan 23, 2026. It is now read-only.
server-side proxy calls#705
Merged
mangelajo merged 1 commit intojumpstarter-dev:mainfrom Oct 14, 2025
Merged
Conversation
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughAdds cached proxy-target resolution to Proxy, centralizes resolution in Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Proxy
participant Resolver as _resolve_proxy_target
participant Target
Caller->>Proxy: call report()/enumerate()/attribute
Proxy->>Resolver: resolve(root?, name)
Note over Resolver: compute target from ref\ncache to _proxy_target
Resolver-->>Proxy: resolved Target (cached)
Proxy->>Target: delegate method / attribute access
Target-->>Proxy: result / value
Proxy-->>Caller: result / value
sequenceDiagram
participant Test as Test/Parent.initialize()
participant Parent
participant ChildProxy as children["serial"] (Proxy)
participant Resolver as _resolve_proxy_target
participant Serial as MockSerial
Test->>Parent: initialize()
Parent->>ChildProxy: connect()
ChildProxy->>Resolver: resolve(self or root, "serial")
Resolver-->>ChildProxy: MockSerial (cached)
ChildProxy->>Serial: connect()
Serial-->>ChildProxy: "connected"
ChildProxy-->>Parent: return "connected"
Parent-->>Test: return
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧬 Code graph analysis (2)packages/jumpstarter/jumpstarter/driver/base.py (1)
packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver_test.py (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
michalskrivanek
force-pushed
the
proxy
branch
from
15ed6cf to
f653f2c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver.py(2 hunks)packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver_test.py(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver_test.py (3)
packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver.py (5)
Composite(17-18)Proxy(22-51)client(12-13)client(27-28)enumerate(45-46)packages/jumpstarter/jumpstarter/common/utils.py (1)
serve(31-39)packages/jumpstarter/jumpstarter/driver/base.py (3)
Driver(56-277)client(101-104)enumerate(219-230)
packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver.py (2)
packages/jumpstarter/jumpstarter/driver/base.py (4)
Driver(56-277)client(101-104)report(198-217)enumerate(219-230)packages/jumpstarter-driver-composite/jumpstarter_driver_composite/driver_test.py (2)
client(15-16)client(32-33)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
- GitHub Check: pytest-matrix (macos-15, 3.12)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
- GitHub Check: pytest-matrix (macos-15, 3.13)
- GitHub Check: pytest-matrix (macos-15, 3.11)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
- GitHub Check: e2e
When using a ref: that is internally used by another driver on the server side, forward the calls to the target driver. Needs to resolve the target device first, and for that we need the actual root device as a reference point to start the search from. Raise on improper use - trying to access report() or other driver call before the target is resolved. Also change report() to not require "root", as the function always returns a report of itself - or the proxy target in case of Proxy driver
michalskrivanek
force-pushed
the
proxy
branch
from
f653f2c to
ba567ee
Compare
mangelajo
reviewed
Oct 14, 2025
| if not path: | ||
| raise ConfigurationError(f"Proxy driver {name} has empty path") | ||
| return reduce(lambda instance, name: instance.children[name], path, root) | ||
| self._proxy_target = reduce(lambda instance, name: instance.children[name], path, root) |
Member
There was a problem hiding this comment.
I use functional programming so little that I had to unshelve my textbooc to remember reduce ! (so sad! X-D)
mangelajo
approved these changes
Oct 14, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a ref: that is internally used by another driver on the server side, forward the calls to the target driver.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests