This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[Backport release-0.7] client lease improvements#720
Merged
mangelajo merged 8 commits intorelease-0.7from Oct 23, 2025
Merged
Conversation
we monitor lease status too frequently (every 5s) which doesn't correspond to the default grpc keepalive which we just made longer. Let's lighten the load a bit and poll less frequent, once in 30s. Changed the info message about lease expiring soon to more friendly "ending in 5 minutes". Also, use effective_begin_time + effective_duration for end time calculation. Once scheduled leases are implemented these may differ from begin_time and duration. (cherry picked from commit 3f9449b)
this allows to create scheduled leases that will start at the requested time. At begin_time the lease will start acquisition that may be delayed or fail if the selected exporter is not available, following the lease acquisition timeout setting. (cherry picked from commit 68f44f6)
"jmp get exporters --with leases" shows lease status and when is the lease expiring. That's more useful that current start time which doesn't tell you for how long it may be held. "jmp get leases" now shows lease begin time (the time it was acquired) in addition to duration. future/scheduled leases show their expected begin time and duration, currently active leases show actual begin time and actual duration so far. (cherry picked from commit f1a1aec)
…ezone info (cherry picked from commit 97b31dc)
this accounts for ended leases as well. If present it has the actual end time of the lease. change column to RELEASE TIME to make sense for ended leases as well (cherry picked from commit 3abd886)
this indicates to the server that we want to see ended leases as well. Default behavior is to only get non-ended leases (pending or currently active) (cherry picked from commit 6d94924)
Use "make protobuf-gen" to be consistent with controller. In python the imports need to be post-processed, unfortunately. (cherry picked from commit 160db62)
(cherry picked from commit b2ce590)
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
mangelajo
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-0.7, triggered by a label in #704.