build(deps): bump actions/download-artifact from 4 to 8#547
build(deps): bump actions/download-artifact from 4 to 8#547dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependabot PR Review SummaryChanges reviewed: Bumps Checks performed:
Note: This is a major version bump (v4 → v8). CI is fully green, indicating the action's interface is backward-compatible for our usage. Conclusion: Safe to merge. CI confirms no regressions. |
raballew
left a comment
There was a problem hiding this comment.
This PR jumps across 4 major versions (v4 -> v5 -> v6 -> v7 -> v8) and has compatibility concerns.
Breaking changes across versions:
- v8: Hash
digest-mismatchnow defaults toerrorinstead ofwarn-- artifacts with digest mismatches will fail the workflow - v8: No longer attempts to unzip all downloaded files (checks Content-Type first)
- v7: Requires Node.js 24 and Actions Runner >= v2.327.1
Critical issue -- upload/download version skew:
The e2e.yaml workflow still uses actions/upload-artifact@v4 (lines 80, 126, 161) for uploading artifacts in the build jobs, while this PR bumps only download-artifact to v8. The new digest enforcement (digest-mismatch: error default) could cause failures if the v4 uploader does not provide compatible digest metadata. build-oci-bundle.yaml uses upload-artifact@v7 which is better aligned but also inconsistent.
Suggested fix options:
- Bump
actions/upload-artifactine2e.yamlfrom v4 to v8 (or at least v7) in the same PR - Or explicitly set
digest-mismatch: warnon the download steps to preserve v4 behavior
The inputs used (name, path) are still supported, so the action interface itself is compatible.
🤖 Generated with Claude Code
|
@ambient-code fix |
|
@raballew Good catch on the version skew. I attempted to push the fix (bumping Here are the exact changes needed:
- uses: actions/upload-artifact@v4
+ uses: actions/upload-artifact@v8
- uses: actions/upload-artifact@v7
+ uses: actions/upload-artifact@v8This will align all A maintainer with repo write access will need to push these changes to the dependabot branch, or these changes can be made in a separate follow-up PR. |
Dependabot ReviewRecommendation: NEEDS COORDINATION with #592 This bumps Issue: upload-artifact and download-artifact must use compatible major versions. These PRs need to be aligned -- either both use v7 or both use a compatible version pair. They should be merged together to avoid breaking the e2e artifact pipeline. Fix: Align download-artifact to v7 to match the upload-artifact v7 in PR #592, or verify v8 download is backward-compatible with v7 uploads. |
|
Action needed: Coordinate with #592 (upload-artifact v7). Either downgrade this to download-artifact v7 to match, or verify cross-version compatibility. Merge both PRs together. |
|
Superseded by #611. |
Bumps actions/download-artifact from 4 to 8.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesbd7976bAdd a setting to specify what to do on hash mismatch and default it toerrorac21fcfMerge pull request #460 from actions/danwkennedy/download-no-unzip15999bfAdd note about package bumps974686eBump the version tov8and add release notesfbe48b1Update test names to make it clearer what they doDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)