Skip to content

build(deps-dev): update esbonio requirement from >=0.16.4 to >=2.0.0 in /python#587

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/python/esbonio-gte-2.0.0
Closed

build(deps-dev): update esbonio requirement from >=0.16.4 to >=2.0.0 in /python#587
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/python/esbonio-gte-2.0.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 16, 2026

Updates the requirements on esbonio to permit the latest version.

Release notes

Sourced from esbonio's releases.

Esbonio Language Server v2.0.0 - 2026-04-11

v2.0.0 - 2026-04-11

Breaking Changes

  • Drop support for Sphinx v6. (#1086)

  • The default values for the following configuration options have been changed.

    • esbonio.logging.level now defaults to info
    • esbonio.server.completion.preferredInsertBehavior now defaults to insert

    (#1094)

  • The default values for the following configuration options have been changed.

    • esbonio.logging.format now defaults to [%(method)s(%(msgid)s)][%(name)s] %(message)s

    Only log messages associated with the LSP methods initialize, initialized, textDocument/didOpen and workspace/didChangeConfiguration are shown by default, regardless of logging level.

    (#1095)

  • The esbonio command no longer starts the server, instead the server is launched by running esbonio server, or by invoking the python -m esbonio.server (#1098)

Features

  • Add support for Sphinx v9 by @​gastmaier (#1085)
  • Introduce the esbonio.logging.enabledMethods option which can be used to override the list of LSP methods for which log messages are shown. (#1095)

Enhancements

  • The esbonio.sphinx.pythonCommand can now be set to a single string, useful when working with virtual environments by @​gastmaier (#1085)
Commits
  • 0832ee4 Esbonio Language Server Release v2.0.0
  • bcb7488 Merge pull request #1102 from swyddfa/develop
  • 6394447 code: Update changelog
  • b1c4bcd workflow: Be specific about bundled esbonio version
  • 509420c code: bump python dependencies
  • 713877c code: bump node dependencies
  • 8bbe9e5 docs: update migration guide
  • 4351749 lsp: Introduce cli subcommands
  • fa30e22 [pre-commit.ci] auto fixes from pre-commit.com hooks
  • 5ad29e2 [pre-commit.ci] pre-commit autoupdate
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 784fc5cb-ab57-4107-b092-ae64ed7e7156

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/pip/python/esbonio-gte-2.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raballew
Copy link
Copy Markdown
Member

Dependabot Review

Recommendation: NEEDS FIX before merge

This bumps esbonio from >=0.16.4 to >=2.0.0 in python/pyproject.toml. CI shows type-check-python and pytest failures.

Root cause: esbonio 2.0.0 removed certifi as a transitive dependency. The code in jumpstarter_cli_common/oidc.py imports certifi directly (line 10), but certifi is not listed as an explicit dependency in python/packages/jumpstarter-cli-common/pyproject.toml. Previously, esbonio pulled it in transitively.

Fix needed: Add certifi as an explicit dependency in python/packages/jumpstarter-cli-common/pyproject.toml since the code imports it directly. This is a missing dependency that was masked by the transitive chain.

The pytest-matrix failures appear to be CI infrastructure timeouts (cancelled during apt package installation), not related to the esbonio upgrade.

@raballew
Copy link
Copy Markdown
Member

Action needed: Add certifi as an explicit dependency in python/packages/jumpstarter-cli-common/pyproject.toml -- it is imported directly in oidc.py but was only available transitively through esbonio <2.0. Once that is fixed, this should be safe to merge.

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code Bot commented Apr 17, 2026

Dependabot PR Review Summary

Changes reviewed: Updates esbonio requirement from >=0.16.4 to >=2.0.0 in python/pyproject.toml.

Checklist

  • go.mod impact: No go.mod changes — no cross-project go.mod updates needed.
  • k8s version update: Not applicable.
  • CI status:FAILINGtype-check-python, pytest-matrix (macos-15, 3.11), and pytest summary all failed.

Analysis

This is a major version bump (0.16.x → 2.0.0) with significant breaking changes:

  • Dropped Sphinx v6 support
  • esbonio CLI command no longer starts the server (now esbonio server)
  • Default config value changes

Root cause of CI failures: The esbonio update changed dependency resolution, exposing a latent bug — certifi is imported by jumpstarter-cli-common/jumpstarter_cli_common/oidc.py but not declared as a dependency in jumpstarter-cli-common/pyproject.toml. Previously certifi was pulled in transitively; the updated dependency tree no longer includes it.

To fix, this PR would need:

  1. Regenerate uv.lock with uv lock for the new dependency tree
  2. Potentially add certifi as an explicit dependency in jumpstarter-cli-common/pyproject.toml

⚠️ Not safe to merge as-is. Needs dependency resolution fixes.

🤖 Automated review by Ambient

Updates the requirements on [esbonio](https://github.com/swyddfa/esbonio) to permit the latest version.
- [Release notes](https://github.com/swyddfa/esbonio/releases)
- [Commits](swyddfa/esbonio@esbonio-language-server-v0.16.5...esbonio-language-server-v2.0.0)

---
updated-dependencies:
- dependency-name: esbonio
  dependency-version: 2.0.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/pip/python/esbonio-gte-2.0.0 branch from 49e49e5 to e2b4eb0 Compare April 17, 2026 09:58
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 17, 2026

Superseded by #612.

@dependabot dependabot Bot closed this Apr 17, 2026
@dependabot dependabot Bot deleted the dependabot/pip/python/esbonio-gte-2.0.0 branch April 17, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

already-checked dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant