test: add regression tests for stop_requested and hook failure filtering#602
test: add regression tests for stop_requested and hook failure filtering#602raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 1 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… states Verify that filterOutNotReadyExporters correctly excludes exporters in HOOK_FAILED and OFFLINE states from lease assignment, serving as a regression test for the server-side safety net added in PR jumpstarter-dev#426. Ref: jumpstarter-dev#245 Generated-By: Forge/20260416_202053_681470_8c18858d_i245 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that _cleanup_after_lease does not report AVAILABLE status when _stop_requested is True, both with skip_after_lease_hook set and with no hook executor configured. This is a regression test for the exporter state machine fix in PR jumpstarter-dev#349 that prevents dying exporters from appearing available to the controller. Ref: jumpstarter-dev#245 Generated-By: Forge/20260416_202053_681470_8c18858d_i245 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b599f77 to
a5ffe26
Compare
Summary
_cleanup_after_leasedoes not report AVAILABLE when_stop_requestedis True (both with and without hook executor)filterOutNotReadyExportersexcludes exporters in HOOK_FAILED and OFFLINE states from lease assignmentRef #245
Test plan
make pkg-test-jumpstarter🤖 Generated with Claude Code