Skip to content

test: add regression tests for stop_requested and hook failure filtering#602

Open
raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
raballew:245-e2e-hook-exit-status
Open

test: add regression tests for stop_requested and hook failure filtering#602
raballew wants to merge 2 commits intojumpstarter-dev:mainfrom
raballew:245-e2e-hook-exit-status

Conversation

@raballew
Copy link
Copy Markdown
Member

Summary

  • Add tests verifying _cleanup_after_lease does not report AVAILABLE when _stop_requested is True (both with and without hook executor)
  • Add tests verifying filterOutNotReadyExporters excludes exporters in HOOK_FAILED and OFFLINE states from lease assignment

Ref #245

Test plan

  • Run make pkg-test-jumpstarter
  • Run Go controller tests

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@raballew has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6cfed2b2-5e52-40d2-946a-91e8348f580c

📥 Commits

Reviewing files that changed from the base of the PR and between 4af710f and a5ffe26.

📒 Files selected for processing (2)
  • controller/internal/controller/lease_controller_test.go
  • python/packages/jumpstarter/jumpstarter/exporter/exporter_test.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

raballew and others added 2 commits April 17, 2026 12:39
… states

Verify that filterOutNotReadyExporters correctly excludes exporters in
HOOK_FAILED and OFFLINE states from lease assignment, serving as a
regression test for the server-side safety net added in PR jumpstarter-dev#426.

Ref: jumpstarter-dev#245
Generated-By: Forge/20260416_202053_681470_8c18858d_i245

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that _cleanup_after_lease does not report AVAILABLE status when
_stop_requested is True, both with skip_after_lease_hook set and with
no hook executor configured. This is a regression test for the exporter
state machine fix in PR jumpstarter-dev#349 that prevents dying exporters from
appearing available to the controller.

Ref: jumpstarter-dev#245
Generated-By: Forge/20260416_202053_681470_8c18858d_i245

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@raballew raballew force-pushed the 245-e2e-hook-exit-status branch from b599f77 to a5ffe26 Compare April 17, 2026 10:45
@raballew raballew marked this pull request as ready for review April 17, 2026 13:53
@raballew raballew enabled auto-merge (squash) April 17, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant