feat: propagate exporter hook status to Lease conditions#607
feat: propagate exporter hook status to Lease conditions#607raballew wants to merge 3 commits intojumpstarter-dev:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I am not sure about this one, this will add a lot of noise and movement to status conditions on the K8s API |
Add LeaseConditionType constants for BeforeLeaseHook, AfterLeaseHook, and HookFailed so the Lease resource can reflect the exporter's hook lifecycle phases. Add corresponding SetStatus helper methods. Closes jumpstarter-dev#446 Generated-By: Forge/20260416_202054_681470_c0f1afed_i446 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add reconcileStatusHookPhase to the lease controller that reads the exporter's ExporterStatusValue and maps it to the corresponding Lease condition (BeforeLeaseHook, AfterLeaseHook, HookFailed, Ready). The Ready condition is now only True when the exporter reaches LeaseReady or has an unspecified status (backward compatibility with old exporters). Closes jumpstarter-dev#446 Generated-By: Forge/20260416_202054_681470_c0f1afed_i446 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ok phase updates The AfterLeaseHook case was not setting the Ready condition to False, which could mislead clients relying on Ready to determine exporter usability. The lease controller also lacked a Watch on Exporter resources, meaning hook phase changes were only propagated on the next requeue timer rather than immediately. Generated-By: Forge/20260416_202054_681470_c0f1afed_i446 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
200639d to
0fadcf7
Compare
Summary
BeforeLeaseHook,AfterLeaseHook, andHookFailedcondition types to the Lease API with correspondingSetStatushelpersreconcileStatusHookPhaseto the lease controller that maps exporter status to Lease conditions, settingReady=Falseduring hook phasesCloses #446
Test plan
🤖 Generated with Claude Code