jumpstarter-driver-gpio: Add read method required by PowerInterface#616
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mangelajo
left a comment
There was a problem hiding this comment.
Thank you very much for the bugfix.
This addresses the following issue: TypeError: Can't instantiate abstract class PowerSwitch without an implementation for abstract method 'read' This adds the read method that will raise an exception because we can't get this kind of data from a gpio. Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
7956f62 to
9370d0d
Compare
|
Successfully created backport PR for |
This addresses the following issue:
TypeError: Can't instantiate abstract class PowerSwitch without an implementation for abstract method 'read'
This adds the read method which return 0 power because we can't get this kind of data from a gpio.