Open
Conversation
Add s:uniq() and use it
mattn
reviewed
Jul 11, 2018
plug.vim
Outdated
| call s:update_impl(1, a:force, a:names) | ||
| endfunction | ||
|
|
||
| function! s:is_exec_helptags(docdir) |
Contributor
There was a problem hiding this comment.
This function name is un-clear to be what should do.
Author
There was a problem hiding this comment.
How about s:is_need_exec_helptags ?
Contributor
There was a problem hiding this comment.
Since I'm not native speaker, I cannot answer best. But has_helptags(x) or helptags_exists(x) ?
cc @junegunn
Author
There was a problem hiding this comment.
I think do_need_exec_helptags() is best.
I'll change it after I came back today or tomorrow. 😙
Thank you mattn 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Junegunn,
Vim's documentation recommends that package include doc/tags.
:help package-create
:help help-writing
In fact, many packages does not contain doc/tags in the repository.
So I think that vim-plug is unconditionally running
:helptagsafter installation and update.I think that should not run
:helptagsin the case of installation or update of that package.Please respect tags that git managed.
This PR is changed to execute
:helptagsonly when either of the following conditions is satisfied.Please check it out.
Note:
Repository of package containing doc/tags (or doc/tags-??x)
--
Best regards,
Hirohito Higashi (h_east)