Skip to content

docs(auth): GitHub OAuth scopes optional#726

Merged
peterpeterparker merged 2 commits intomainfrom
feat/oauth-optional
Jan 23, 2026
Merged

docs(auth): GitHub OAuth scopes optional#726
peterpeterparker merged 2 commits intomainfrom
feat/oauth-optional

Conversation

@peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented Jan 23, 2026

Parameters are ignored when a GitHub Apps is used. In that case the permissions of the apps are used by GitHub.

Given GitHub ignores the params, we keep the current implementation that use default and just add comments - for now - in the code.

This way the libs interfaces are nice from a dx perspective as they automatically use the expected scopes for OAtuh.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

size-limit report 📦

Path Size
@junobuild/admin 5.81 KB (0%)
@junobuild/core 14.38 KB (0%)
@junobuild/core-worker 21.77 KB (0%)
@junobuild/core-peer 14.38 KB (0%)
@junobuild/core-standalone 68.71 KB (0%)
@junobuild/utils 276 B (0%)
@junobuild/errors 930 B (0%)
@junobuild/functions 1.63 KB (0%)
@junobuild/analytics 12.3 KB (0%)
@junobuild/config 6.88 KB (0%)
@junobuild/auth 2.52 KB (0%)
@junobuild/cdn 971 B (0%)
@junobuild/storage 988 B (0%)
@junobuild/ic-client/actor 6.9 KB (0%)
@junobuild/ic-client/webauthn 1.96 KB (0%)
@junobuild/ic-client/utils 174 B (0%)

@peterpeterparker peterpeterparker changed the title feat(auth): GitHub OAuth scopes optional docs(auth): GitHub OAuth scopes optional Jan 23, 2026
@peterpeterparker peterpeterparker merged commit 1c9a2e0 into main Jan 23, 2026
13 checks passed
@peterpeterparker peterpeterparker deleted the feat/oauth-optional branch January 23, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant