Open
Conversation
rgbkrk
reviewed
Nov 7, 2025
| "deletable": { | ||
| "description": "Whether the cell is deletable.", | ||
| "type": "boolean" | ||
| }, |
Member
There was a problem hiding this comment.
Each of these new optional boolean fields need to have "default": true since the absence of these fields would likely be interpreted as false. That or it ends up in ambiguous territory even though we'd probably want to assume these are true in notebooks.
Something like:
"editable": {
"description": "Whether the cell is editable.",
"type": "boolean",
"default": true
},
for each
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a number of notebooks that I've created and maintained through a mix of Jupyter Notebook, Jupyter Lab, and the VSCode Jupyter Extension. I was opening googlecolab/colabtools#5675, and noticed that
metadata.slide_typewasn't in the spec. It's used by multiple official Jupyter projects, so seems like it should be…?In going down that rabbit hole, noticed a few other metadata properties that were missing from the JSONSchema. Added those here as well.
I didn't update the
format_description.rst— happy to do so if you like.Thanks!