WIP, publish error tracebacks on iopub#201
Draft
tomjakubowski wants to merge 1 commit intojupyterlite:mainfrom
Draft
WIP, publish error tracebacks on iopub#201tomjakubowski wants to merge 1 commit intojupyterlite:mainfrom
tomjakubowski wants to merge 1 commit intojupyterlite:mainfrom
Conversation
This ensures that when an Output ipywidget is used as a context manager,
errors raised inside the context are rendered in the Output widget.
```
out = Output()
out
with out:
raise RuntimeError("oh no! an error occurred")
```
However, it does not suppress the error in the original cell, which is
to say the error is rendered both in the original cell and in the Output
widget. This behavior is in contrast to Jupyter Lab and Notebook, which
do suppress the error in the original cell. Fixing this is a TODO.
This patch also handles the case where an ipywidgets handler, without
the `@out.capture()` decorator, raises an exception. Such exceptions
are now seen in the log console.
TODOs:
- [ ] Suppress error in the original cell
Contributor
|
|
Author
|
When I say this patch currently fails to suppress the error in the original cell, I mean this. Compare the cell outputs in Jupyter Notebook with ipykernel: 
and the cell outputs in Jupyter Lite, with this patch to pyodide-kernel: 
In Lite, the error is now incorrectly appearing in two cells, when it should only be in the Output widget's cell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that when an Output ipywidget is used as a context manager, errors raised inside the context are rendered in the Output widget.
However, it does not suppress the error in the original cell, which is to say the error is rendered both in the original cell and in the Output widget. This behavior is in contrast to Jupyter Lab and Notebook, which do suppress the error in the original cell. Fixing this is a TODO.
This patch also handles the case where an ipywidgets handler, without the
@out.capture()decorator, raises an exception. Such exceptions are now seen in the log console.TODOs: