Merged
Conversation
JamesGeorg
approved these changes
Dec 13, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| shopt -s nocasematch | ||
|
|
||
| COMMITS="$(git log --format=%B ${{ github.event.before }}..${{ github.sha }})" | ||
| PR_TITLE='${{ github.event.pull_request.title }}' |
Check failure
Code scanning / CodeQL
Code injection Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To prevent potential code injection vulnerabilities with user-controlled input, the recommended GitHub Actions pattern is to pass the value into an environment variable and reference that variable from the shell. This involves two changes:
- Add an entry under
env:in the problematicrun:step, assigning something likePR_TITLE: ${{ github.event.pull_request.title }}. - In the
run:block, remove the direct variable assignment (PR_TITLE='...'), and simply use$PR_TITLEas needed.
In this case, we:
- Remove line 46 (
PR_TITLE='${{ github.event.pull_request.title }}'). - Add
env:under the step, definingPR_TITLE: ${{ github.event.pull_request.title }}. - All subsequent references to
$PR_TITLEin therun:block already use the correct syntax.
No new methods or imports are required.
Suggested changeset
1
.github/workflows/release.yml
| @@ -43,8 +43,6 @@ | ||
| run: | | ||
| shopt -s nocasematch | ||
|
|
||
| PR_TITLE='${{ github.event.pull_request.title }}' | ||
|
|
||
| if [[ "$PR_TITLE" =~ (\[breaking\]|\[major\]) ]]; then | ||
| echo "release_type=major" >> $GITHUB_OUTPUT | ||
| elif [[ "$PR_TITLE" =~ \[minor\] ]]; then | ||
| @@ -55,6 +53,8 @@ | ||
|
|
||
| shopt -u nocasematch | ||
| shell: bash | ||
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||
|
|
||
| - name: Conventional Changelog Action | ||
| id: changelog |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.