Skip to content

feat(java): Publishing to central-sonatype.#638

Merged
knutties merged 2 commits intomainfrom
feat/java/publish-sonatype
Aug 11, 2025
Merged

feat(java): Publishing to central-sonatype.#638
knutties merged 2 commits intomainfrom
feat/java/publish-sonatype

Conversation

@ShreyBana
Copy link
Contributor

Publishing for Maven Central via Sonatype.

@ShreyBana ShreyBana requested a review from a team as a code owner August 5, 2025 12:11
@ShreyBana ShreyBana force-pushed the feat/java/publish-sonatype branch 11 times, most recently from 621af2a to bbc8b94 Compare August 6, 2025 12:14
@ShreyBana ShreyBana changed the title [WIP] feat(java): Publishing to central-sonatype. feat(java): Publishing to central-sonatype. Aug 6, 2025
@ShreyBana ShreyBana force-pushed the feat/java/publish-sonatype branch from bbc8b94 to 39c5d9b Compare August 6, 2025 12:38
@@ -0,0 +1,46 @@
name: Java Checks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better name would be helpful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any suggestions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShreyBana - pardon my ignorance here - what does this workflow do? or is it only to detect failure and upload things in case of failure?

That might help in getting to a right name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a main build workflow that happens on main changes (which is what is supposed to power the build passing badge in the main README.md) - and this should be part of that workflow ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knutties - It just compiles the java code atm. Testing requires more setup.
As for your second question, I am not aware of one, don't know if @Datron knows better.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShreyBana does Java sdk pre-publish checks work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Datron - This has been moved to our CI checks workflow.

@ShreyBana ShreyBana force-pushed the feat/java/publish-sonatype branch from 39c5d9b to 9491815 Compare August 7, 2025 09:05
@ShreyBana ShreyBana requested a review from Datron August 7, 2025 09:17
@knutties knutties force-pushed the feat/java/publish-sonatype branch from 9491815 to 3adaff6 Compare August 7, 2025 14:31
@@ -0,0 +1,46 @@
name: Java Checks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShreyBana does Java sdk pre-publish checks work?

}

extra["displayName"] = "Superposition SDK"
description = "Java SDK for Superposition."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShreyBana can we read a markdown file here or should we share a link to our Java SDK documentation website/javadoc? Same for the provider as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All javadocs published in maven-central are available at javadoc.io. We can just link that in our main readme.

@knutties knutties added the P0 label Aug 11, 2025
@ShreyBana ShreyBana force-pushed the feat/java/publish-sonatype branch 4 times, most recently from 385cff6 to 8144be7 Compare August 11, 2025 08:52
@ShreyBana ShreyBana requested review from Datron and knutties August 11, 2025 09:51
@knutties knutties force-pushed the feat/java/publish-sonatype branch from 8144be7 to 2c20ddc Compare August 11, 2025 13:30
@knutties knutties merged commit 5750a54 into main Aug 11, 2025
5 checks passed
@knutties knutties deleted the feat/java/publish-sonatype branch August 11, 2025 16:28
venkatk-git pushed a commit to venkatk-git/superposition that referenced this pull request Aug 12, 2025
* feat(java): Publishing to central-sonatype.

* feat(java): Publishing to central-sonatype.

---------

Co-authored-by: Shrey Bana <shreybana26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants