Conversation
Collaborator
Author
|
Closing this one as it is redone as part of superposition_core in #796 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current cac-toml implementation did not use the superposition_core for config resolution and did not have the updated map interface for the context.
Solution
This solution switches to using a ; separated key-value pair for contexts instead of the PEG parser for expressions. We could make this into its own provider - say superposition_toml_provider.
Environment variable changes
NA
Pre-deployment activity
NA
Post-deployment activity
NA
API changes
NA
Possible Issues in the future
NA