refactor: provider-refactor by knutties · Pull Request #792 · juspay/superposition

knutties · 2025-12-18T13:03:54Z

Problem

Describe the problem you are trying to solve here

Solution

Provide a brief summary of your solution so that reviewers can understand your code

Environment variable changes

What ENVs need to be added or changed

Pre-deployment activity

Things needed to be done before deploying this change (if any)

Post-deployment activity

Things needed to be done after deploying this change (if any)

API changes

Endpoint	Method	Request body	Response Body
API	GET/POST, etc	request	response

Possible Issues in the future

Describe any possible issues that could occur because of this change

semanticdiff-com · 2025-12-18T13:03:57Z

Review changes with

Changed Files

File	Status
Cargo.lock	Unsupported file format
crates/superposition_provider/Cargo.toml	Unsupported file format
crates/superposition_provider/README.md	Unsupported file format
crates/superposition_provider/examples/all_features.rs	0% smaller
crates/superposition_provider/examples/local_http.rs	0% smaller
crates/superposition_provider/src/data_source.rs	0% smaller
crates/superposition_provider/src/data_source/http.rs	0% smaller
crates/superposition_provider/src/lib.rs	0% smaller
crates/superposition_provider/src/providers.rs	0% smaller
crates/superposition_provider/src/providers/local.rs	0% smaller
crates/superposition_provider/src/traits.rs	0% smaller
design-docs/README.md	Unsupported file format
design-docs/provider-enhancement-plan-multi-language.md	Unsupported file format
design-docs/provider-enhancement-plan.md	Unsupported file format

knutties · 2026-02-13T03:56:48Z

crates/superposition_provider/src/traits.rs

+    /// Resolve all features for the given evaluation context
+    ///
+    /// Returns a map of all feature keys to their resolved values
+    async fn resolve_all_features(


resolve_all suffices ? To avoid confusion between config or features.

knutties · 2026-02-13T04:41:15Z

crates/superposition_provider/src/traits.rs

+/// This trait provides methods to get information about experiments
+/// and which variants are applicable for a given context.
+#[async_trait]
+pub trait FeatureExperimentMeta: Send + Sync {


Should this be called FeatureExperimentMetaProvider ?

knutties · 2026-02-13T04:55:09Z

crates/superposition_provider/src/data_source.rs

+#[async_trait]
+pub trait SuperpositionDataSource: Send + Sync {
+    /// Fetch the latest configuration from the data source
+    async fn fetch_config(&self) -> Result<ConfigData>;


Do we need a Context and Prefix Filter support here ?

async fn fetch_filtered_config(&self, context: Option<Map<String, Value>, prefix_filter: Option<&[String]>,) -> Result<ConfigData>;

knutties · 2026-02-13T04:55:41Z

crates/superposition_provider/src/data_source.rs

+    /// Fetch experiment data from the data source
+    ///
+    /// Returns None if the data source doesn't support experiments
+    async fn fetch_experiments(&self) -> Result<Option<ExperimentData>>;


Do we need a context filter version for this?

knutties · 2026-02-13T06:21:33Z

crates/superposition_provider/src/data_source.rs

+    /// Fetch experiment data from the data source
+    ///
+    /// Returns None if the data source doesn't support experiments
+    async fn fetch_experiments(&self) -> Result<Option<ExperimentData>>;


Suggested change

async fn fetch_experiments(&self) -> Result<Option<ExperimentData>>;

async fn fetch_active_experiments(&self) -> Result<Option<ExperimentData>>;

Add support for

async fn fetch_filtered_active_experiments(&self, context: Option<&EvaluationContext>, prefix_filter: Option<&[String]>) -> Result<Option<ExperimentData>>;

Introduce following instead of above:
fetch_candidate_experiments (partial match)
fetch_matching_experiments (exact match)
taking Map and Prefix as args.

knutties · 2026-02-13T06:26:23Z

crates/superposition_provider/src/data_source.rs

+    async fn fetch_experiments(&self) -> Result<Option<ExperimentData>>;
+
+    /// Get a human-readable name for this data source
+    fn source_name(&self) -> &str;


skip - add if needed.

knutties · 2026-02-13T06:27:42Z

crates/superposition_provider/src/data_source.rs

+    fn supports_experiments(&self) -> bool;
+
+    /// Close and cleanup resources used by this data source
+    async fn close(&self) -> Result<()>;


Check if needed.

knutties · 2026-02-13T06:43:53Z

crates/superposition_provider/src/traits.rs

+    ) -> Result<Map<String, Value>>;
+
+    /// Get metadata about this provider
+    fn metadata(&self) -> &AllFeatureProviderMetadata;


skip - not needed

knutties · 2026-02-13T06:45:28Z

crates/superposition_provider/src/traits.rs

+#[async_trait]
+pub trait AllFeatureProvider: Send + Sync {
+    /// Resolve all features for the given evaluation context
+    ///


Add a sugar function for

get_default

knutties · 2026-02-13T06:48:37Z

crates/superposition_provider/src/traits.rs

+    /// Resolve all features for the given evaluation context
+    ///
+    /// Returns a map of all feature keys to their resolved values
+    async fn resolve_all_features(


Support generic type deserialization in these methods.

Check if it is no-op for Map<String, Value>.

knutties · 2026-02-13T06:50:49Z

crates/superposition_provider/src/traits.rs

+    ///
+    /// This returns information about which experiments are active
+    /// and which variants have been selected for the given context.
+    async fn get_experiment_metadata(


Suggested change

async fn get_experiment_metadata(

async fn get_satisfied_experiments(

This is already supported in datasource - remove from here.

knutties · 2026-02-13T07:08:57Z

crates/superposition_provider/src/traits.rs

+    ///
+    /// Returns None if the experiment is not applicable for the given context
+    /// Returns Some(variant_id) if a variant was selected
+    async fn get_experiment_variant(


Not needed.

knutties added 3 commits December 18, 2025 18:19

refactor: provider refactor

29fb027

refactor: cleanup file stuff

db48235

refactor: remove ununsed stuff

9cdbb24

knutties changed the title ~~Provider refactor v1~~ refactor: provider-refactor Dec 18, 2025

knutties added 2 commits December 19, 2025 14:01

refactor: align examples

062c76b

refactor: other language refactor plan

e4ac62f

knutties commented Feb 13, 2026

View reviewed changes

	async fn fetch_experiments(&self) -> Result<Option<ExperimentData>>;
	async fn fetch_active_experiments(&self) -> Result<Option<ExperimentData>>;

	async fn get_experiment_metadata(
	async fn get_satisfied_experiments(

Conversation

knutties commented Dec 18, 2025

Problem

Solution

Environment variable changes

Pre-deployment activity

Post-deployment activity

API changes

Possible Issues in the future

Uh oh!

semanticdiff-com bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knutties Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knutties Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

semanticdiff-com bot commented Dec 18, 2025 •

edited

Loading

knutties Feb 13, 2026 •

edited

Loading

knutties Feb 13, 2026 •

edited

Loading