-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add toml parsing to superposition_core #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d8ba710
9e97fbd
3ae2d19
658fd98
f4424e2
fc1511f
501a679
4015a53
8011db3
71785aa
851ad16
6b50bf5
c9947f0
914f48f
2fa5d17
ee7c441
b1ac61e
fe00dfb
6153889
0b3ebb5
6617fbc
ec98120
bfb2bb5
f7f4dc5
09b4d4d
47dcfb6
920898c
f306004
6f5efb7
2193f13
e843c28
dfcb4aa
fcf1f32
5b19f46
5eedd65
903a701
5229878
ee2ab8c
f495155
145ffee
4d847ea
0a6a5f2
5e79d43
f603bdc
8745c15
e47c2e0
97b92af
75ce84a
a1efce2
ac96c5f
0fc81f2
20eb52e
c993eac
c264a42
466ae7e
3f0b7f6
0eeab8d
25da504
06569f5
3d70706
5883f45
d5671e0
9782275
bc8ba16
50833c5
19841f1
5d9b199
5ef51f7
cd07076
b719275
19d6d45
579e1ce
f0e307c
4d9fd3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,15 @@ library | |
| exposed-modules: FFI.Superposition | ||
| -- other-modules: | ||
| -- other-extensions: | ||
| build-depends: base ^>=4.18.2.0 | ||
| build-depends: base >=4.17 && <5, | ||
| aeson, | ||
| bytestring, | ||
| text | ||
| hs-source-dirs: lib | ||
| default-language: GHC2021 | ||
| default-extensions: CApiFFI | ||
| extra-libraries: superposition_core | ||
| include-dirs: ../../../target/include | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check for README files and build documentation in haskell clients directory
find clients/haskell -type f -name "README*" -o -name "*.md" | head -20Repository: juspay/superposition Length of output: 397 🏁 Script executed: #!/bin/bash
# Check for Makefile, build scripts in haskell clients directory
find clients/haskell -type f \( -name "Makefile" -o -name "build.sh" -o -name "build.py" -o -name "*.sh" \) | head -20Repository: juspay/superposition Length of output: 46 🏁 Script executed: #!/bin/bash
# Search for any documentation about Rust in the haskell clients directory
find clients/haskell -type f \( -name "*.md" -o -name "*.txt" -o -name "README*" \) -exec cat {} \; 2>/dev/null | head -50Repository: juspay/superposition Length of output: 1682 🏁 Script executed: #!/bin/bash
# Examine the cabal file itself and nearby structure
cat -n clients/haskell/superposition-bindings/superposition-bindings.cabal | head -60Repository: juspay/superposition Length of output: 1528 🏁 Script executed: #!/bin/bash
# Check the directory structure around the Haskell bindings
ls -la clients/haskell/
ls -la clients/haskell/superposition-bindings/Repository: juspay/superposition Length of output: 1271 🏁 Script executed: #!/bin/bash
# Check cabal.project file
cat clients/haskell/cabal.projectRepository: juspay/superposition Length of output: 170 🏁 Script executed: #!/bin/bash
# Check default.nix file for Rust build handling
cat clients/haskell/default.nixRepository: juspay/superposition Length of output: 1216 🏁 Script executed: #!/bin/bash
# Look for GitHub Actions or CI/CD workflows
find . -type d -name ".github" -o -name ".gitlab-ci.yml" 2>/dev/null | head -5Repository: juspay/superposition Length of output: 73 🏁 Script executed: #!/bin/bash
# Check if there's a top-level README or build documentation
cat README.md 2>/dev/null | head -100Repository: juspay/superposition Length of output: 7289 🏁 Script executed: #!/bin/bash
# Check for any setup.hs that might handle the build order
cat clients/haskell/superposition-bindings/Setup.hsRepository: juspay/superposition Length of output: 109 🏁 Script executed: #!/bin/bash
# Look for any Nix flake or build files at root
ls -la | grep -E "flake|nix|Makefile|setup"Repository: juspay/superposition Length of output: 244 🏁 Script executed: #!/bin/bash
# Search for GitHub Actions workflows that build Haskell code
find .github/workflows -name "*.yaml" -o -name "*.yml" 2>/dev/null | head -10Repository: juspay/superposition Length of output: 193 🏁 Script executed: #!/bin/bash
# Check for any workflow that mentions haskell or cabal
find .github -type f \( -name "*.yaml" -o -name "*.yml" \) -exec grep -l "haskell\|cabal\|superposition-bindings" {} \;Repository: juspay/superposition Length of output: 46 🏁 Script executed: #!/bin/bash
# Look at flake.nix to understand the complete build system
cat flake.nix | head -100Repository: juspay/superposition Length of output: 2633 🏁 Script executed: #!/bin/bash
# Check the CI workflow files to see how Haskell is built
cat .github/workflows/ci_check_pr.yamlRepository: juspay/superposition Length of output: 15520 🏁 Script executed: #!/bin/bash
# Check the release workflow to see how it handles Haskell builds
cat .github/workflows/release.yaml | head -150Repository: juspay/superposition Length of output: 5746 🏁 Script executed: #!/bin/bash
# Check nix workflow
cat .github/workflows/nix.yamlRepository: juspay/superposition Length of output: 449 🏁 Script executed: #!/bin/bash
# Look for any documentation about building in clients/haskell
find clients/haskell -name "*.md" -exec cat {} \;Repository: juspay/superposition Length of output: 4822 The hardcoded include path requires clarification for non-Nix builds. The Consider:
🤖 Prompt for AI Agents |
||
|
|
||
| test-suite superposition-bindings-test | ||
| import: warnings | ||
|
|
@@ -36,7 +40,9 @@ test-suite superposition-bindings-test | |
| hs-source-dirs: test | ||
| main-is: Main.hs | ||
| build-depends: | ||
| base ^>=4.18.2.0, | ||
| base >=4.17 && <5, | ||
| HUnit, | ||
| async, | ||
| aeson, | ||
| bytestring, | ||
| superposition-bindings | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing, should we link to libraries in target dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Datron - yes, we are linking to libraries in target dir for the
bindings-testmake target - are you saying we should or we should not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knutties I assumed we were copying the libs from target to root dir for testing since the comment
If we are linking with binaries in target dir then we can remove this gitignore. Though this is a nitpick and need not be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for python it copies the library instead of using the target path - so is useful for now. Need to see if the Python code can be changed to pick from the target itself.