fix(dashboard): address Go backend CodeRabbit review comments#85
Merged
justinjdev merged 2 commits intofeat/command-dashboardfrom Mar 21, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- queue.go: handle rand.Read error, use unique tmp path per PID, add file locking (flock) for cross-process safety - data.go: handle UserHomeDir error on config write path - server.go: NewServer returns error instead of log.Fatalf - ws.go: snapshot conns under RLock before writing to avoid holding mutex during network I/O; fix misleading CheckOrigin comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…otent close - ws.go: introduce wsConn wrapper with per-connection write mutex (gorilla/websocket requires serialized writes) and sync.Once Close to prevent double-close on concurrent Remove + Broadcast failure - data.go: move error check before suffix filter in handleAutopsies to avoid masking DB errors as 404 - data.go: use PID-unique tmp path in handleConfigWrite, consistent with queue.go SaveCommandQueue Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
justinjdev
force-pushed
the
worktree-fix-go-backend-coderabbit-pr76
branch
from
aabb8f1 to
92f291b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rand.Readerror ingenerateID()UserHomeDirerror on config write pathNewServerto return(*Server, error)instead of callinglog.FatalfBroadcastto not hold mutex during network I/O (snapshot-then-write)CheckOrigincomment in WebSocket upgradergo mod tidyContext
Addresses Go backend review comments from PR #76. Six of the original 12 items were already fixed in prior commits; this PR covers the remaining 7.
Test plan
go test ./...)go build ./...)go vet ./...clean🤖 Generated with Claude Code